[v16] [aws] exclude session recordings from S3 sync in teleport-renew-cert
#47622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR excludes `records` directory from the sync when renewing the letsencrypt certificate. When doing the wildcard sync, `aws sync` downloads the `records` folder which contains audit logs for the cluster which causes failures because of no space left on the disk. The certbot hook `teleport-upload-cert` doesn't use the `--delete` flag so the records are never purged from S3 on upload Fixes #27884 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-actions
bot
requested review from
hugoShaka,
marcoandredinis,
vapopov and
zmb3
marcoandredinis
approved these changes
Oct 16, 2024
vapopov
approved these changes
Oct 16, 2024
hugoShaka
approved these changes
Oct 16, 2024
public-teleport-github-review-bot
bot
removed the request for review
from zmb3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #47610 to branch/v16
changelog: Fixes a bug where Let's Encrypt certificate renewal failed in AMI and HA deployments due to insufficient disk space caused by syncing audit logs.