Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use proxy from env for compatible integrations #47611

Closed
wants to merge 2 commits into from
+15 −2
Closed

fix: use proxy from env for compatible integrations #47611

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d82ae01
fix: use proxy from env for pagerduty integration
hugodocto Oct 16, 2024
d7e91a4
feat: add proxy conf for integrations that support it
hugodocto Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions integrations/access/pagerduty/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ func NewPagerdutyClient(conf PagerdutyConfig, clusterName, webProxyAddr string,
Transport: &http.Transport{
MaxConnsPerHost: pdMaxConns,
MaxIdleConnsPerHost: pdMaxConns,
Proxy: http.ProxyFromEnvironment,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add support for other integrations?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tigrato! I just pushed a new commit where I add this conf to the other integrations that use the resty.Client

}}).
SetBaseURL(conf.APIEndpoint).
SetHeader("Accept", "application/vnd.pagerduty+json;version=2").
Expand Down
Loading