Client tools auto update #47466
Open
Client tools auto update #47466
+1,372
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vapopov
added
the
no-changelog
vapopov
commented
Oct 10, 2024
| return 0, trace.Errorf("invalid size") | ||
| } | ||
| avail := stat.Bavail * uint64(stat.Bsize) | ||
| avail := uint64(stat.Bavail) * uint64(stat.Bsize) |
There was a problem hiding this comment.
This change related to this comment #47060 (comment)
also I'm locally checking linter for warnings related touint64(stat.Bavail)
vapopov
force-pushed
the
vapopov/client-auto-update
branch
from
5bc4215
to
ddcbaf9
Compare
sclevine
reviewed
Oct 15, 2024
Move integration tests to client tools specific dir Use context cancellation with SIGTERM, SIGINT Remove cancelable tee reader with context replacement Renaming
Fix archive cleanup if hash is not valid Limit the archive write bytes
vapopov
force-pushed
the
vapopov/client-auto-update
branch
from
144d573
to
d5dd770
Compare
vapopov
force-pushed
the
vapopov/client-auto-update
branch
from
355c675
to
5f5688e
Compare
sclevine
reviewed
Oct 16, 2024
Base URL renaming
sclevine
reviewed
Oct 17, 2024
Replace hash for bytes matching Proper temp file close for archive download
vapopov
force-pushed
the
vapopov/client-auto-update
branch
from
c860415
to
b019206
Compare
sclevine
approved these changes
Oct 17, 2024
lib/autoupdate/feature.go
Outdated
| // FlagEnt represents enterprise version. | ||
| FlagEnt = 1 << iota | ||
| // FlagFips represents enterprise version with fips feature enabled. | ||
| FlagFips |
There was a problem hiding this comment.
Suggested change
| FlagFips | |
| FlagFIPS |
lib/autoupdate/tools/utils.go
Outdated
| } | ||
| } | ||
|
|
||
| return filepath.Join(filepath.Clean(home), ".tsh", "bin"), nil |
There was a problem hiding this comment.
Note that filepath.Join runs filepath.Clean on the result for you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR implemented logic for client tools auto update {tsh, tctl} described in this RFD #39805
Update logic downloads Teleport binaries from CDN, extracts data in tools sub-directory (going to be used
$TELEPORT_HOME/bin/{UUID-update-pkg}/{tsh,tctl}) and creates symlinks for {tsh,tctl} to$TELEPORT_HOME/bin/{tsh,tctl}.Added integration tests which compiles updater binary with update logic only to simulate command execution with requested version to downloads them from fake test CDN server.