Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SSO MFA - add missing SAML MFA fields #47291

Merged
merged 4 commits into from
Oct 10, 2024
Merged

feat: SSO MFA - add missing SAML MFA fields #47291

merged 4 commits into from
Oct 10, 2024

Conversation

Joerger
Copy link
Contributor

@Joerger Joerger commented Oct 7, 2024

Follow up to #46703 adding missing fields needed for the SSO MFA flow.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@Joerger Joerger mentioned this pull request Oct 7, 2024
Merged
@Joerger Joerger added the no-changelog Indicates that a PR does not require a changelog entry label Oct 7, 2024
@Joerger Joerger mentioned this pull request Oct 5, 2024
Open
rosstimothy
rosstimothy reviewed Oct 7, 2024
View reviewed changes
lib/services/saml.go Outdated Show resolved Hide resolved
@Joerger Joerger force-pushed the joerger/add-missing-saml-mfa-fields branch from fc10b9a to c4646c1 Compare October 8, 2024 01:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

🤖 Vercel preview here: https://docs-5q5a95hht-goteleport.vercel.app/docs/ver/preview

@Joerger Joerger force-pushed the joerger/add-missing-saml-mfa-fields branch from e31504b to 6872b63 Compare October 8, 2024 18:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

🤖 Vercel preview here: https://docs-isr4plvqi-goteleport.vercel.app/docs/ver/preview

@Joerger Joerger force-pushed the joerger/add-missing-saml-mfa-fields branch from 6872b63 to 427612a Compare October 8, 2024 19:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

🤖 Vercel preview here: https://docs-41de9ob8x-goteleport.vercel.app/docs/ver/preview

@Joerger Joerger force-pushed the joerger/add-missing-saml-mfa-fields branch from 427612a to 451d611 Compare October 8, 2024 21:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

🤖 Vercel preview here: https://docs-3c9qx6f37-goteleport.vercel.app/docs/ver/preview

@Joerger Joerger force-pushed the joerger/add-missing-saml-mfa-fields branch from 451d611 to 612bc4f Compare October 8, 2024 21:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

🤖 Vercel preview here: https://docs-b45ljdcql-goteleport.vercel.app/docs/ver/preview

@Joerger
Copy link
Contributor Author

Joerger commented Oct 10, 2024

@gzdunek @smallinsky friendly ping to review

@Joerger Joerger force-pushed the joerger/add-missing-saml-mfa-fields branch from 612bc4f to d1ecfa2 Compare October 10, 2024 20:37
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-hm9ytn4lr-goteleport.vercel.app/docs/ver/preview

@Joerger Joerger added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
@Joerger Joerger added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
@Joerger Joerger added this pull request to the merge queue Oct 10, 2024
Merged via the queue into master with commit 66058cd Oct 10, 2024
43 checks passed
@Joerger Joerger deleted the joerger/add-missing-saml-mfa-fields branch October 10, 2024 22:49
mvbrock pushed a commit that referenced this pull request Oct 16, 2024
@Joerger @mvbrock
feat: SSO MFA - add missing SAML MFA fields (#47291)
bd861ce 
* Add missing SAML MFA settings.

* Validate saml mfa settings and set fields from entity_descriptor.

* Reuse entity descriptor from base connector when applicable.

* Upate terraform schema and docs and crds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugoShaka hugoShaka hugoShaka left review comments

@gzdunek gzdunek gzdunek approved these changes

@rosstimothy rosstimothy rosstimothy approved these changes

Assignees
No one assigned
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Joerger @hugoShaka @gzdunek @rosstimothy