Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebDiscover: add clarifying diagram on deploying ecs step for RDS #46915

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kimlisa
Copy link
Contributor

@kimlisa kimlisa commented Sep 25, 2024

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty to run those svgs through ImageOptim. It reduced the size of each svg by 10% without reducing quality.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! 🙏

@marcoandredinis
Copy link
Contributor

It looks much better but I'm wondering if the every user will know what the Teleport Proxy is.
At least for Cloud Users, that's a term that most Day 1 users will no know.
Maybe we just changed it to Your Teleport Cluster ?

Also, Teleport's image repo could be replaced with Teleport's Container registry, which I think is a more correct term.

Want to deploy a database service manually ...

Should this be:
Do you want to deploy a database service manually ...?

I was wondering if we want to be more explicit about new items in the diagram.
I think we decided to use bold to identify those. If so, then ECS Task and Teleport Database Service are the only identifiers that should be in bold (it looks like Teleport Proxy, Teleport's image repo and the Security Groups are also in bold?). Also, we should probably be explicit about it, like this AWS Docs diagram
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v15 backport/branch/v16 no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants