Migrate lib/backend to slog #46865
Merged
Migrate lib/backend to slog #46865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/backend_logging
branch
from
a815434
to
887dade
Compare
rosstimothy
force-pushed
the
tross/backend_logging
branch
from
887dade
to
c6bf875
Compare
github-actions
bot
added
audit-log
rosstimothy
added
the
no-changelog
hugoShaka
reviewed
Sep 24, 2024
| @@ -310,7 +308,7 @@ func New(cfg EventsConfig) (*Log, error) { | |||
| go firestorebk.RetryingAsyncFunctionRunner(b.svcContext, retryutils.LinearConfig{ | |||
| Step: b.RetryPeriod / 10, | |||
| Max: b.RetryPeriod, | |||
| }, b.Logger, b.purgeExpiredEvents, "purgeExpiredEvents") | |||
| }, b.logger.With("task_name", "purge_expired_events"), b.purgeExpiredEvents) | |||
There was a problem hiding this comment.
task_name appears in many places, should the key be in a constant?
hugoShaka
approved these changes
Sep 24, 2024
Tener
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts all cluster state backend logging from logrus to slog. Additionally, the Firestore events backend was also migrated because it imports backend/firestore and some of the changes would've broken the build otherwise.