Add AutoUpdate gRPC service implementation #46544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vapopov
added
the
no-changelog
vapopov
force-pushed
the
vapopov/autoupdate-grpc
branch
from
3ff3cf7
to
778a93c
Compare
vapopov
commented
Sep 12, 2024
| autoUpdateServiceServer, err := autoupdatev1.NewService(autoupdatev1.ServiceConfig{ | ||
| Authorizer: cfg.Authorizer, | ||
| Backend: cfg.AuthServer.Services, | ||
| Cache: cfg.AuthServer.Services, |
There was a problem hiding this comment.
this going to be replaced to cfg.AuthServer.Cache in next pr with cache implementation
rosstimothy
reviewed
Sep 12, 2024
lib/authz/permissions.go
Outdated
Comment on lines
916
to
917
| types.NewRule(types.KindAutoUpdateConfig, services.RO()), | ||
| types.NewRule(types.KindAutoUpdateVersion, services.RO()), |
There was a problem hiding this comment.
Do we need to update any of the preset roles?
There was a problem hiding this comment.
I'll move this one to client and cache implementation, we need to have this to be able access resources without auth for find endpoint
rosstimothy
reviewed
Sep 16, 2024
rosstimothy
approved these changes
Sep 16, 2024
vapopov
force-pushed
the
vapopov/autoupdate-grpc
branch
from
7d55aa3
to
2896303
Compare
sclevine
approved these changes
Sep 16, 2024
vapopov
added a commit
that referenced
this pull request
Sep 16, 2024
* Add gRPC service implementation * CR changes * Add auth for read operation
vapopov
added a commit
that referenced
this pull request
Sep 16, 2024
* Add gRPC service implementation * CR changes * Add auth for read operation
vapopov
added a commit
that referenced
this pull request
Sep 16, 2024
* Add gRPC service implementation * CR changes * Add auth for read operation
This was referenced Sep 16, 2024
vapopov
added a commit
that referenced
this pull request
Sep 16, 2024
* Add gRPC service implementation * CR changes * Add auth for read operation
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
* Add AutoUpdate gRPC service implementation (#46544) * Add gRPC service implementation * CR changes * Add auth for read operation * Replace service test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR implemented gRPC service for auto updates resources (config/version)