[v16] Require all audit events to be able to be trimmed #46499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@capnspacehook - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
github-actions
bot
added
audit-log
This comment was marked as resolved.
This comment was marked as resolved.
flyinghermit
approved these changes
Sep 11, 2024
r0mant
approved these changes
Sep 11, 2024
public-teleport-github-review-bot
bot
removed the request for review
from greedy52
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
capnspacehook
force-pushed
the
capnspacehook/backport/v16/45931
branch
from
8ecba3d
to
c3cca79
Compare
* ensure 'db.session.result' and 'desktop.recording' events can be converted from EventFields * add TrimToMaxSize methods for all audit events and make it a required method * ensure callers of TrimToMaxSize check the size of the returned event --------- Co-authored-by: Andrew LeFevre <Andrew LeFevre>
capnspacehook
force-pushed
the
capnspacehook/backport/v16/45931
branch
from
c3cca79
to
94c80f8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #45931.
changelog: allow all audit events to be trimmed if necessary