Set annotations on teleport-kube-agent StatefulSet
#46393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrato
reviewed
Sep 9, 2024
| @@ -13,6 +13,10 @@ metadata: | |||
| {{- if .Values.extraLabels.deployment }} | |||
| {{- toYaml .Values.extraLabels.deployment | nindent 4 }} | |||
| {{- end }} | |||
| {{- if .Values.annotations.deployment }} | |||
| annotations: | |||
| {{- toYaml .Values.annotations.deployment | nindent 4 }} | |||
There was a problem hiding this comment.
can we use separate annotations for the statefulset?
the deployment is a legacy thing we are trying to get rid of
There was a problem hiding this comment.
Hrm, I see that but I think there's a general trend of the "deployment" values being used within this template (e.g extraLabels). It seems like it would be more odd for this to be inconsistent with that. We probably ought to do another PR at somepoint which just shifts all of these values to using those explicitly stated as for the "statefulset".
There was a problem hiding this comment.
Also, our documentation for the values file already states today that it will be applied to the StatefulSet, so if anything, we have a bug today in that it is not.
# annotations.deployment(object) -- contains the Kubernetes annotations
# put on the `Deployment` or `StatefulSet` resource created by the chart.
deployment: {}
tigrato
approved these changes
Sep 9, 2024
hugoShaka
approved these changes
Sep 9, 2024
public-teleport-github-review-bot
bot
removed the request for review
from marcoandredinis
zmb3
approved these changes
Sep 9, 2024
|
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Sep 10, 2024
* set annotations on teleport-kube-agent statefulset * empty commit to trigger ci --------- Co-authored-by: Sean Liao <sean+git@liao.dev>
strideynet
added a commit
that referenced
this pull request
Sep 10, 2024
* set annotations on teleport-kube-agent statefulset * empty commit to trigger ci --------- Co-authored-by: Sean Liao <sean+git@liao.dev>
strideynet
added a commit
that referenced
this pull request
Sep 10, 2024
* set annotations on teleport-kube-agent statefulset * empty commit to trigger ci --------- Co-authored-by: Sean Liao <sean+git@liao.dev>
This was referenced Sep 10, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
* set annotations on teleport-kube-agent statefulset * empty commit to trigger ci --------- Co-authored-by: Sean Liao <sean+git@liao.dev>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
* set annotations on teleport-kube-agent statefulset * empty commit to trigger ci --------- Co-authored-by: Sean Liao <sean+git@liao.dev>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
* set annotations on teleport-kube-agent statefulset * empty commit to trigger ci --------- Co-authored-by: Sean Liao <sean+git@liao.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buddies #45687
Originally contributed by @seankhliao
changelog: The teleport-kube-agent chart now correctly propagates configured annotations when deploying a StatefulSet.