Try to narrow down TestTrustBundleCache_Run flake #46377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
added
no-changelog
rosstimothy
approved these changes
Sep 9, 2024
zmb3
approved these changes
Sep 9, 2024
public-teleport-github-review-bot
bot
removed request for
timothyb89 and
Joerger
strideynet
deleted the
strideynet/try-to-narrow-down-trust-bundle-cache-flake
branch
|
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Sep 10, 2024
strideynet
added a commit
that referenced
this pull request
Sep 10, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Smash out an initial "hacky" implementation of TrustDomainCache * Wire trustbundlecache into FetchX509SVID * Wire into SDS endpoint * Strip out old CA event handler * Initialize TrustBundleCache as needed * Fix panic due to uninitialized subscriber map * Add basic tests for TrustBundleCache * Detect older Auth Server versions without SPIFFEFederation resource support * Support AllowPartialSuccess * Tidy up logging of old auth server handling * Fix TestSDS_FetchSecrets test * Add more test cases for SDS with federated trust domain support * Remove irrelevant comment * Add test for TrustBundleCache * Enable parallel for TestTrustBundleCache_RUn * Fix linter complaints * Appease linter * Tidy up retry loop * Try to narrow down trust bundle cache flake (#46377) * Workload ID: Add support for Federated Trust Bundles into `spiffe-svid` output (#46023) * Hack on IncludeFederatedTrustBundle option * Refactor to better re-use trust bundle set init code * Add retry loop * Pass cache into output * Rewrite subscriber behaviour to avoid racines * Simplify GetBundleSet * Add godocs * Update lib/tbot/service_spiffe_svid_output.go Co-authored-by: Tim Buckley <tim@goteleport.com> --------- Co-authored-by: Tim Buckley <tim@goteleport.com> --------- Co-authored-by: Tim Buckley <tim@goteleport.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Smash out an initial "hacky" implementation of TrustDomainCache * Wire trustbundlecache into FetchX509SVID * Wire into SDS endpoint * Strip out old CA event handler * Initialize TrustBundleCache as needed * Fix panic due to uninitialized subscriber map * Add basic tests for TrustBundleCache * Detect older Auth Server versions without SPIFFEFederation resource support * Support AllowPartialSuccess * Tidy up logging of old auth server handling * Fix TestSDS_FetchSecrets test * Add more test cases for SDS with federated trust domain support * Remove irrelevant comment * Add test for TrustBundleCache * Enable parallel for TestTrustBundleCache_RUn * Fix linter complaints * Appease linter * Tidy up retry loop * Try to narrow down trust bundle cache flake (#46377) * Workload ID: Add support for Federated Trust Bundles into `spiffe-svid` output (#46023) * Hack on IncludeFederatedTrustBundle option * Refactor to better re-use trust bundle set init code * Add retry loop * Pass cache into output * Rewrite subscriber behaviour to avoid racines * Simplify GetBundleSet * Add godocs * Update lib/tbot/service_spiffe_svid_output.go Co-authored-by: Tim Buckley <tim@goteleport.com> --------- Co-authored-by: Tim Buckley <tim@goteleport.com> --------- Co-authored-by: Tim Buckley <tim@goteleport.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't repro locally even with CPU limits applied. This adds a little more logging (that'll be useful anyway, and see if that helps narrow it down in the CI as well)
https://github.com/gravitational/teleport.e/actions/runs/10758968887/job/29835068933