Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] Add a link text label to the ClusterAlert resource #46284

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

bl-nero
Copy link
Contributor

@bl-nero bl-nero commented Sep 5, 2024

Backport #45972 to branch/v16

Note: the intended result is for this change to have no impact on the UI, but set the new alert labels so that they are there when the UI that uses it is introduced after update to v17.

bl-nero and others added 4 commits September 5, 2024 10:43
This label allows to customize text on a button that contains the alert
link.
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
@bl-nero bl-nero added the no-changelog Indicates that a PR does not require a changelog entry label Sep 5, 2024
@bl-nero
Copy link
Contributor Author

bl-nero commented Sep 5, 2024

Retested manually to confirm impact on returned labels, but no impact on UI:

  • Alert about too many Windows desktops — by adding 6 non-AD Windows desktops
  • Alert about inability to report usage — by configuring a phony Prehog URI.
  • Custom alerts - by using tctl alerts create.

@zmb3
Copy link
Collaborator

zmb3 commented Sep 16, 2024

@fspmarshall PTAL

@zmb3 zmb3 added this pull request to the merge queue Sep 18, 2024
Merged via the queue into branch/v16 with commit fa3e23a Sep 18, 2024
43 of 44 checks passed
@zmb3 zmb3 deleted the bot/backport-45972-branch/v16 branch September 18, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants