Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle Exadata docs #45732

Merged
merged 19 commits into from
Aug 30, 2024
Merged

Oracle Exadata docs #45732

merged 19 commits into from
Aug 30, 2024

Conversation

Tener
Copy link
Contributor

@Tener Tener commented Aug 23, 2024

This guide has fewer options than usual, in particular with respect to the database CA, as it documents the configuration that is known to be working. I've dropped a number of includes because of that, instead inlining their contents and tailoring it to the particulars of this case.

Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments but approving now to not block later.

Comment on lines 56 to 58
<Admonition type="warning">
Database names are only enforced for PostgreSQL and MongoDB databases.
</Admonition>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just remove the reference to this flag from this guide? Otherwise it's confusing that we're mentioning it here only to say that it's not actually supported.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is not applicable to Oracle, but database guides tend to just include docs/pages/includes/database-access/create-user.mdx, which has all these details.

Copy link

🤖 Vercel preview here: https://docs-10lbqg4ga-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-q8zz5982g-goteleport.vercel.app/docs/ver/preview

Co-authored-by: STeve (Xin) Huang <xin.huang@goteleport.com>
Co-authored-by: Roman Tkachenko <roman@goteleport.com>
Copy link

🤖 Vercel preview here: https://docs-ef72x97rg-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-qmag4b3tm-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-kbqmjri1k-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-pieh6prxx-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-ak4r4lzf8-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-nnvp6uve7-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-mjs030g8f-goteleport.vercel.app/docs/ver/preview

@Tener Tener added this pull request to the merge queue Aug 30, 2024
Merged via the queue into master with commit a27499f Aug 30, 2024
39 of 40 checks passed
@Tener Tener deleted the tener/oracle-exadata-docs branch August 30, 2024 12:00
@public-teleport-github-review-bot

@Tener See the table below for backport results.

Branch Result
branch/v15 Create PR
branch/v16 Create PR

This was referenced Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants