Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signing And Notarizing Plugins Targetting Darwin #45557

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Signing And Notarizing Plugins Targetting Darwin #45557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1077bc9
Updating darwin plugin builds to notarize binaries
doggydogworld Aug 13, 2024
773f140
Updating event-handler signing to include binaries
doggydogworld Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions integrations/event-handler/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,19 @@ RELEASE_MESSAGE = "Building with GOOS=$(OS) GOARCH=$(ARCH)."
build:
GOOS=$(OS) GOARCH=$(ARCH) $(CGOFLAG) go build -o $(BUILDDIR)/teleport-event-handler $(BUILDFLAGS)

# darwin-signed-build is a wrapper around the build target that ensures it is codesigned
include ../../darwin-signing.mk
.PHONY: darwin-signed-build
darwin-signed-build: BINARIES=$(BINARY)
darwin-signed-build: build
$(NOTARIZE_BINARIES)

.PHONY: release
ifeq ($(OS),darwin)
release: darwin-signed-build
else
release: build
endif
@echo "---> $(RELEASE_MESSAGE)"
mkdir $(RELEASE_NAME)
cp -rf $(BINARY) \
Expand Down
15 changes: 13 additions & 2 deletions integrations/terraform/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,20 @@ endif
rm -r ./tfschema/github.com/
@go run ./gen/main.go

.PHONY: release
# darwin-signed-build is a wrapper around the build target that ensures it is codesigned
include ../../darwin-signing.mk
.PHONY: darwin-signed-build
darwin-signed-build: BINARIES=$(BUILDDIR)/terraform-provider-teleport
ifeq ($(OS)-$(ARCH),darwin-universal)
release: build-darwin-universal
darwin-signed-build: build-darwin-universal
else
darwin-signed-build: build
endif
$(NOTARIZE_BINARIES)

.PHONY: release
ifeq ($(OS),darwin)
release: darwin-signed-build
else
release: build
endif
Expand Down
Loading