Fix desktop listener PROXY mode setting #32922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atburke
approved these changes
Oct 3, 2023
|
It is always accessed through proxy, but sometimes via direct dial and sometimes via tunnel. Do we expect this change to work in both cases? |
|
@zmb3 yep, because Proxy never sends unsigned PROXY headers, only signed ones (and they are not affected by this change) |
zmb3
approved these changes
Oct 3, 2023
public-teleport-github-review-bot
bot
removed the request for review
from ravicious
AntonAM
force-pushed
the
anton/fix-desktop-listener
branch
from
364c01c
to
fc81f68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROXYProtocol mode setting was erroneously propagated from Proxy configuration into multiplexer listener of the desktop service. But desktop service should never actually process unsigned PROXY headers, since it's always contacted through the Proxy.