Fix kubectl log commands when they refer to deployment instead of pod
#32912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a typo on our automatic updates documentation where the `kubectl log` commands should refer to the deployment since Kubernetes appends random strings to deployment names when building the pod name. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-actions
bot
requested review from
lsgunn-teleport,
ptgott,
r0mant,
xinding33 and
zmb3
zmb3
reviewed
Oct 3, 2023
| ``` | ||
|
|
||
| And by consulting its logs: | ||
|
|
||
| ```code | ||
| $ kubectl logs <your-agent-release>-updater | ||
| $ kubectl logs deployment/<your-agent-release>-updater |
There was a problem hiding this comment.
Is it a deployment or a statefulset? Looks like the latter to me.
There was a problem hiding this comment.
The updater is a deployment. The agent itself is a statefulset
https://github.com/gravitational/teleport/blob/master/examples/chart/teleport-kube-agent/templates/updater/deployment.yaml
|
🤖 Vercel preview here: https://docs-hs4lcrv2l-goteleport.vercel.app/docs/ver/14.x |
ptgott
approved these changes
Oct 3, 2023
zmb3
approved these changes
Oct 4, 2023
public-teleport-github-review-bot
bot
removed request for
r0mant,
xinding33 and
lsgunn-teleport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a typo on our automatic updates documentation where the
kubectl logcommands should refer to the deployment since Kubernetes appends random strings to deployment names when building the pod name.