Pin Teleport Terraform Provider to Teleport major version #32784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
capnspacehook,
lsgunn-teleport,
ptgott,
r0mant,
xinding33 and
zmb3
|
🤖 Vercel preview here: https://docs-39rf0c4qp-goteleport.vercel.app/docs/ver/14.x |
The previous constrain `>= (=teleport.version=)` allows Terraform to pick any version bigger than the specified version. This is a problem because `>= 12.0.0` can actually select `14.0.0` which breaks our client guarentees when connecting to Auth server. This PR forces Terraform to pick any version `>=12.0.0` and `< 13.0.0`. The pessimist version constrain prevents Terraform provider to use versions outside of the specified major version. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
force-pushed
the
tigrato/fix-terraform-pinned-version
branch
from
de6e693
to
0a32ffc
Compare
strideynet
approved these changes
Sep 29, 2023
marcoandredinis
approved these changes
Sep 29, 2023
|
🤖 Vercel preview here: https://docs-mudnw0j2j-goteleport.vercel.app/docs/ver/14.x |
ptgott
approved these changes
Oct 2, 2023
public-teleport-github-review-bot
bot
removed request for
r0mant,
zmb3,
capnspacehook,
xinding33 and
lsgunn-teleport
|
🤖 Vercel preview here: https://docs-b9wcyr68i-goteleport.vercel.app/docs/ver/14.x |
This was referenced Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous constrain
>= (=teleport.version=)allows Terraform to pick any version bigger than the specified version. This is a problem because>= 12.0.0can actually select14.0.0which breaks our client guarantees when connecting to Auth server.This PR forces Terraform to pick any version
>=12.0.0and< 13.0.0. The pessimist version constrain prevents Terraform provider to use versions outside of the specified major version.