-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate DeleteMFADevice and move tests to its "sync" variant #32773
Conversation
Branched from #32767 to avoid a deprecation warning (and a conflicting change for me). If this happens to be approved first I can drop that commit and add a temporary nolint instead. May be reviewed commit-by-commit if you prefer, although there's a tiny bit of churn between afedcf1 and 2176700. |
Test failures look unrelated, I'll take a closer look later. |
Friendly ping @AntonAM ? |
Thanks for the quick review, everyone! If the base is not ready by Monday I'll drop that commit and merge only the changes you reviewed. |
c7bc35e
to
b009aa6
Compare
Deprecate DeleteMFADevice, various of its top-level messages and interface appearances, and move all tests (but one) to DeleteMFADeviceSync.
I've taken the opportunity to consolidate our "last device" deletion tests as well.
This paves the ground for an easy code cleanup when the time comes.
#20343