Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DeleteMFADevice and move tests to its "sync" variant #32773

Merged
merged 10 commits into from
Oct 2, 2023

Conversation

codingllama
Copy link
Contributor

Deprecate DeleteMFADevice, various of its top-level messages and interface appearances, and move all tests (but one) to DeleteMFADeviceSync.

I've taken the opportunity to consolidate our "last device" deletion tests as well.

This paves the ground for an easy code cleanup when the time comes.

#20343

@codingllama
Copy link
Contributor Author

Branched from #32767 to avoid a deprecation warning (and a conflicting change for me). If this happens to be approved first I can drop that commit and add a temporary nolint instead.

May be reviewed commit-by-commit if you prefer, although there's a tiny bit of churn between afedcf1 and 2176700.

@codingllama
Copy link
Contributor Author

Test failures look unrelated, I'll take a closer look later.

@codingllama
Copy link
Contributor Author

Friendly ping @AntonAM ?

@codingllama
Copy link
Contributor Author

Thanks for the quick review, everyone! If the base is not ready by Monday I'll drop that commit and merge only the changes you reviewed.

Base automatically changed from codingllama/tshmfarm-sync to master October 2, 2023 17:35
@codingllama codingllama force-pushed the codingllama/deletemfadevice-cleanup branch from c7bc35e to b009aa6 Compare October 2, 2023 17:39
@codingllama codingllama added this pull request to the merge queue Oct 2, 2023
Merged via the queue into master with commit ba90737 Oct 2, 2023
31 checks passed
@codingllama codingllama deleted the codingllama/deletemfadevice-cleanup branch October 2, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants