Change default SQL Server database command to sqlcmd
#28918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
reviewed
Jul 10, 2023
| @@ -568,6 +578,10 @@ func (c *CLICommandBuilder) getSQLServerCommand() *exec.Cmd { | |||
| args = append(args, "-d", c.db.Database) | |||
| } | |||
|
|
|||
| if c.isSqlcmdAvailable() { | |||
| return exec.Command(sqlcmdBin, args...) | |||
There was a problem hiding this comment.
Does it support exactly the same arguments as mssql-cli?
There was a problem hiding this comment.
Yes, and since we're always using a tunneled proxy, there is no need to have additional flags.
There was a problem hiding this comment.
Sounds good, adding a comment to that effect might be helpful here.
There was a problem hiding this comment.
There is a comment on the function godoc.
r0mant
approved these changes
Jul 10, 2023
smallinsky
approved these changes
Jul 11, 2023
|
@gabrielcorado See the table below for backport results.
|
This was referenced Jul 11, 2023
|
we may want to fallback to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given
mssql-cliis being deprecated in favor ofsqlcmd, we're switching it to be the default command, with fallback tomssql-cliwhen it is not present onPATH.Note: Both, Golang and ODBC-based implementations are supported.