Allow for resource limits and requests for pre-deployment jobs #23077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the ability to allow for requests and limits to be added to the predeploy_job like already done for deployments.
Add the ability for the proxy predeploy_job to have limits and requests like the deployment. Using same values from Values file.
hugoShaka
requested changes
Mar 14, 2023
There was a problem hiding this comment.
The template change looks good :)
Can you add tests covering the feature?
You can find test guidelines here, and might want to copy the main deployment resource tests.
Adding tests for resource limits on predeploy job for auth and proxy.
|
@hugoShaka I have added the tests. It was my first time building those, please let me know if I missed something. |
yjperez
changed the title
hugoShaka
approved these changes
Mar 15, 2023
Co-authored-by: Hugo Shaka <hugo.hervieux@goteleport.com>
Co-authored-by: Hugo Shaka <hugo.hervieux@goteleport.com>
Co-authored-by: Hugo Shaka <hugo.hervieux@goteleport.com>
Co-authored-by: Hugo Shaka <hugo.hervieux@goteleport.com>
|
@r0mant no, this is only applicable starting Teleport V12. |
@yjperez Then you need |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to allow for requests and limits to be added to the predeploy_job like already done for deployments.