Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use conditional imports to trigger development instanceOf() #4221

Closed
wants to merge 2 commits into from

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Oct 8, 2024

This PR changes this library to use the development version of instanceOf when a condition is set rather than based on a Node JS specific environment variable.

See:
#4075
#4188

@yaacovCR yaacovCR requested a review from a team as a code owner October 8, 2024 10:24
Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit ad77f7c
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6706e4d3fa1d120008a75807
😎 Deploy Preview https://deploy-preview-4221--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Oct 8, 2024

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR force-pushed the test-ts branch 4 times, most recently from 76bc6d9 to 8959fb3 Compare October 8, 2024 19:48
@yaacovCR yaacovCR marked this pull request as draft October 8, 2024 19:56
@yaacovCR yaacovCR force-pushed the test-ts branch 2 times, most recently from f138246 to 6cd3d4d Compare October 9, 2024 12:26
@yaacovCR yaacovCR marked this pull request as ready for review October 9, 2024 12:30
@yaacovCR yaacovCR added the PR: breaking change 💥 implementation requires increase of "major" version number label Oct 9, 2024
@yaacovCR yaacovCR force-pushed the test-ts branch 2 times, most recently from a85cbb5 to 930619a Compare October 9, 2024 14:42
@yaacovCR yaacovCR changed the title demo imports handling instanceOf use conditional imports to trigger development instanceOf() Oct 9, 2024
Changes this library to use the development version of instanceOf when a condition is set rather than based on a Node JS specific environment variable.
@yaacovCR
Copy link
Contributor Author

Closing, this precludes bundler-free web versions

@yaacovCR yaacovCR closed this Oct 10, 2024
@yaacovCR yaacovCR deleted the test-ts branch October 10, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: breaking change 💥 implementation requires increase of "major" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant