Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow UnionTypeComposer #48

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Conversation

theasmoth
Copy link
Contributor

faced problem that UTC cannot be used as pagination item
this PR resolves problem

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021

Codecov Report

Merging #48 (9713738) into master (85dc8c7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   97.77%   97.80%   +0.02%     
==========================================
  Files           3        3              
  Lines          90       91       +1     
  Branches       29       29              
==========================================
+ Hits           88       89       +1     
  Misses          2        2              
Impacted Files Coverage Δ
src/types.ts 100.00% <ø> (ø)
src/pagination.ts 96.72% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85dc8c7...9713738. Read the comment docs.

@nodkz
Copy link
Member

nodkz commented Aug 6, 2021

Good improvement! Tnx! I've just fixed some typescript definition problems.

@theasmoth what do you think about Scalar & Enum as items for pagination?

@nodkz nodkz mentioned this pull request Aug 6, 2021
@theasmoth
Copy link
Contributor Author

@nodkz

Good improvement! Tnx! I've just fixed some typescript definition problems.

Oh, sorry. Forgot about that

@theasmoth what do you think about Scalar & Enum as items for pagination?

Scalar items could be useful (less than OTC, but...), doubt about Enum

@nodkz nodkz merged commit 58939d4 into graphql-compose:master Aug 6, 2021
@nodkz
Copy link
Member

nodkz commented Aug 6, 2021

@theasmoth enums are the same kind as scalars. So if we allow scalars there is no reason to not accept enums.

Thanks for PR 🙏

@github-actions
Copy link

github-actions bot commented Aug 6, 2021

🎉 This PR is included in version 8.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants