Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature management: identify "features" used by a subgraph #2715

Closed
azf20 opened this issue Aug 17, 2021 · 1 comment · Fixed by #2682
Closed

Feature management: identify "features" used by a subgraph #2715

azf20 opened this issue Aug 17, 2021 · 1 comment · Fixed by #2682
Assignees
@tilacog

Comments

@azf20
Copy link
Contributor

azf20 commented Aug 17, 2021

  • Add an endpoint to return the features used by a given subgraph (identified by a Qm hash) - ipfsOnEthereumContracts, grafting, nonFatalErrors, fullTextSearch
  • Add features of interest to the "features" part of the manifest (specVersion bump)
  • Check for presence of the specified features on subgraph deployment (for the spec version). Verify that the error is printed nicely when deploying from the CLI

This is a requirement for the Arbitration Charter (establishes a pattern for tracking new features, which can then be used to determine network rewards & verification)
@azf20
Copy link
Contributor Author

azf20 commented Aug 17, 2021

PR: #2682

@tilacog tilacog mentioned this issue Aug 17, 2021
Merged
9 tasks
@leoyvens leoyvens mentioned this issue Aug 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tilacog tilacog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature Management and Validation graphprotocol/graph-node
2 participants
@tilacog @azf20