Out of gas tx triggers subgraph call handler

[fnanni-0]

This transaction ran out of gas. The purpose of this transaction was to execute 3 different transactions through a transaction batcher contract. You can see that the first of those transactions is calling executeRequest() of this contract.

My understanding is that this reverted transaction should not have triggered any call in the subgraph. However, it did trigger executeRequest() call handler. Is this a bug or am I missing something?

[leoyvens]

This is probably because in the traces the call to the contract did not error, even though the transaction itself reverted.

[fnanni-0]

Hi @leoyvens, does this have an ETA?

[leoyvens]

No ETA yet, but I'll share some thoughts on what it takes to fix this:

• A transaction is considered reverted if either the gas spent equals the provided gas, or if the status field has a value of 0, see EIP-658.

• Gas spent and the status are fields of the transaction receipt, but for historical blocks Graph Node does not fetch receipts. So fixing this will incur a performance hit to the sync time of all subgraphs employing call handlers.

• A decision needs to be made if this fix will be versioned in Graph Node and therefore apply to existing subgraphs, or if this fix will be versioned in the manifest.

[fnanni-0]

Got it, thanks for the explanation!