-
-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ws subscriptions for nuxt and h3 (with doc) #2204
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome; so happy to see this being updated to a more stable implementation! Some early comments; my main question is around the path to the websocket handler, and why serv
can't handle that internally rather than having the user write additional code. If there's a good reason behind this it's fine, I just want to know what that reason is (as an outsider unfamiliar with H3/Nuxt).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I've done some refactoring, and have some questions
Description
Add the support of ws subscriptions for nuxt and h3
Performance impact
unknown (not)
Security impact
unknown (not)
Checklist
yarn lint:fix
passes.yarn test
passes.RELEASE_NOTES.md
file (if one exists).