Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ws subscriptions for nuxt and h3 (with doc) #2204

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Dodobibi
Copy link
Contributor

@Dodobibi Dodobibi commented Oct 4, 2024

Description

Add the support of ws subscriptions for nuxt and h3

Performance impact

unknown (not)

Security impact

unknown (not)

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: 828ed9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome; so happy to see this being updated to a more stable implementation! Some early comments; my main question is around the path to the websocket handler, and why serv can't handle that internally rather than having the user write additional code. If there's a good reason behind this it's fine, I just want to know what that reason is (as an outsider unfamiliar with H3/Nuxt).

grafast/grafserv/src/servers/h3/v1/index.ts Outdated Show resolved Hide resolved
grafast/website/grafserv/servers/h3.md Outdated Show resolved Hide resolved
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I've done some refactoring, and have some questions

grafast/grafserv/src/servers/h3/v1/index.ts Show resolved Hide resolved
grafast/grafserv/src/servers/h3/v1/index.ts Outdated Show resolved Hide resolved
grafast/website/grafserv/servers/nuxt.md Outdated Show resolved Hide resolved
grafast/website/grafserv/servers/nuxt.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🌱 In Progress
Development

Successfully merging this pull request may close these issues.

2 participants