Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 preset should use Amber preset #2188

Merged
merged 14 commits into from
Oct 1, 2024
Merged

V4 preset should use Amber preset #2188

merged 14 commits into from
Oct 1, 2024

Conversation

benjie
Copy link
Member

@benjie benjie commented Sep 30, 2024

Description

Fixes graphile/crystal-pre-merge#415

Some subtle issues with plugin/preset ordering/etc may be surfaced, plus this fixes a bug so anyone relying on the bug may have their configuration's tweaked - recommend fingerprinting your schema before and after this change and look for differences.

Performance impact

Startup costs increased.

Security impact

None known.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Sep 30, 2024

🦋 Changeset detected

Latest commit: 95b8666

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
postgraphile Patch
graphile-build-pg Patch
graphile-config Patch
graphile-utils Patch
pgl Patch
graphile Patch
@localrepo/grafast-bench Patch
@dataplan/pg Patch
grafast Patch
@grafserv/persisted Patch
grafserv Patch
ruru Patch
graphile-build Patch
@dataplan/json Patch
ruru-components Patch
@localrepo/grafast-website Patch
graphile-export Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie merged commit b97469b into main Oct 1, 2024
36 checks passed
@benjie benjie deleted the v4-amber-preset branch October 1, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Investigate: having V4 preset extend amber preset breaks things
1 participant