-
-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul loadOne docs #2185
Overhaul loadOne docs #2185
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty close!
Could you also turn the return type in loadMany
to PromiseOrDirect<ReadonlyArray<ReadonlyArray<unknown>>>
- I forgot to indicate it's a list of lists.
Co-authored-by: Benjie <benjie@jemjie.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ace; thanks! 🙌
Description
In the same style as #2183
Performance impact
Security impact
Checklist