Remove default filter from WellKnownMap

[nckswt]

Description

I noticed an issue where some modules weren't being exported properly. Full discord discussion here.

Problem

My source code has:

import CityTimezones from 'city-timezones';
import snakeCase from 'lodash/snakeCase';

...
export const pgInsert = EXPORTABLE((snakeCase) => async (pgClient, table, data) => {
  const columns = Object.keys(data).map(snakeCase).join(', ');
  ...
}, [snakeCase]);

and I'm exporting modules like:

import * as CityTimezones from 'city-timezones';
import * as lodashSnakeCase from 'lodash/snakeCase';

...
  await exportSchema(schema, exportFileLocation, {
    mode: "typeDefs",
    modules: {
      'city-timezones': CityTimezones,
      'lodash/snakeCase': lodashSnakeCase,
    }
  });

But my exported schema has snakeCase undefined:

const pgInsert2 = async (pgClient, table, data) => {
  const columns = Object.keys(data).map(undefined).join(", ");
  // !! Note how snakeCase has become undefined /\

Resolution

After this line I added the following:

  console.log({ moduleName, exportName, exp: obj[exportName] });
  console.log(exportName !== "default");
  console.log(!wellKnownMap.has(obj[exportName]));

and noticed

{
  moduleName: 'city-timezones',
  exportName: 'lookupViaCity',
  exp: [Function: lookupViaCity]
}
true
true
{
  moduleName: 'lodash/snakeCase',
  exportName: 'default',
  exp: [Function (anonymous)]
}
false
true

So, for now, I'm simply removing the exportName !== "default" conditional and my schema seems to be exported as expected, but I don't know why that was there in the first place or the other downstream effects.

Performance impact

unknown, likely none.

Security impact

unknown, likely none.

Checklist

• My code matches the project's code style and yarn lint:fix passes.
• I've added tests for the new feature, and yarn test passes.
• I have detailed the new feature in the relevant documentation.
• I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
• If this is a breaking change I've explained why.

[changeset-bot]

🦋 Changeset detected

Latest commit: 4cc6d36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
graphile-export	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[benjie]

Thanks! Hopefully this is a more thorough fix and cleans up some existing code too 👍