Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable backward pagination of functions by default #2158

Merged
merged 6 commits into from
Aug 16, 2024
Merged

Conversation

benjie
Copy link
Member

@benjie benjie commented Aug 16, 2024

Description

Fixes graphile/graphile-engine#713

Performance impact

Negligible.

Security impact

Improvement.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

… options (`before`, `last`) on functions by default - add `+backwards` behavior to these functions to enable. If you're using the V4 preset you should be unaffected by this change because it enables `+backwards` by default.
Copy link

changeset-bot bot commented Aug 16, 2024

🦋 Changeset detected

Latest commit: 46ce046

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
graphile-build-pg Patch
postgraphile Patch
graphile-utils Patch
pgl Patch
graphile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie merged commit b54dd33 into main Aug 16, 2024
36 checks passed
@benjie benjie deleted the no-unsortable-last branch August 16, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

"last" on function connections without @sortable doesn't make sense?
1 participant