Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add executors to registry #2156

Merged
merged 10 commits into from
Aug 16, 2024
Merged

Add executors to registry #2156

merged 10 commits into from
Aug 16, 2024

Conversation

benjie
Copy link
Member

@benjie benjie commented Aug 16, 2024

Description

Fixes #2076

Primarily a DX concern.

Performance impact

Negligible.

Security impact

None known.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

…ed to be looked up from a resource (this causes confusion) - instead they can be referenced directly. By default there's one executor called `main`, i.e. `build.input.pgRegistry.pgExecutors.main`.
… related methods are called before the 'init' phase is complete.
Copy link

changeset-bot bot commented Aug 16, 2024

🦋 Changeset detected

Latest commit: 5930521

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
graphile-build Patch
graphile-build-pg Patch
postgraphile Patch
@dataplan/pg Patch
graphile-utils Patch
pgl Patch
graphile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie merged commit abbae04 into main Aug 16, 2024
36 checks passed
@benjie benjie deleted the registry-executor branch August 16, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

(v5) I'd like get a generic executor from build.input.pgRegistry inside a makeExtendSchemaPlugin.
1 participant