Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary check in PgSelect optimize #2151

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Conversation

benjie
Copy link
Member

@benjie benjie commented Aug 9, 2024

Description

Fixes #2131

Performance impact

Improvement.

Security impact

Unknown.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Aug 9, 2024

🦋 Changeset detected

Latest commit: c7526b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
postgraphile Patch
@dataplan/pg Patch
graphile-utils Patch
pgl Patch
graphile Patch
graphile-build-pg Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie merged commit 1d74d55 into main Aug 9, 2024
36 checks passed
@benjie benjie deleted the fieldargs-pgselect-bug branch August 9, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Unable to pass FieldArg as parameter for resource .get()
1 participant