Remove unnecessary check

graphile · Aug 9, 2024 · 91bcb0d · 91bcb0d
1 parent a5b1e53
commit 91bcb0d
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/grafast/dataplan-pg/src/steps/pgSelect.ts b/grafast/dataplan-pg/src/steps/pgSelect.ts
@@ -2634,15 +2634,11 @@ ${lateralText};`;
                   return sql`${step.toSQL()}::${
                     codec.sqlType
                   } = ${identifierMatch}`;
-                } else if (isStaticInputStep(step)) {
+                } else {
                   return sql`${this.placeholder(
                     step,
                     codec,
                   )} = ${identifierMatch}`;
-                } else {
-                  throw new Error(
-                    `Expected ${step} (${i}th dependency of ${this}; step with id ${dependencyIndex}) to be a PgClassExpressionStep`,
-                  );
                 }
               }),
               // Note the WHERE is now part of the JOIN condition (since
@@ -2705,14 +2701,10 @@ ${lateralText};`;
               return this.where(
                 sql`${step.toSQL()}::${codec.sqlType} = ${identifierMatch}`,
               );
-            } else if (isStaticInputStep(step)) {
+            } else {
               return this.where(
                 sql`${this.placeholder(step, codec)} = ${identifierMatch}`,
               );
-            } else {
-              throw new Error(
-                `Expected ${step} (${i}th dependency of ${this}; step with id ${dependencyIndex}) to be a PgClassExpressionStep`,
-              );
             }
           });
           this.mergePlaceholdersInto(table);