Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error after updating to 2.62.0 #67

Closed
aleksandrlat opened this issue Sep 28, 2021 · 6 comments
Closed

Fatal error after updating to 2.62.0 #67

aleksandrlat opened this issue Sep 28, 2021 · 6 comments
Labels

Comments

@aleksandrlat
Copy link

We receive same error as here #66 (comment)

Object.defineProperty called on non-object
Call Stack
 eval
  node_modules/awesome-phonenumber/index.js:3:8
 ./node_modules/awesome-phonenumber/index.js
  vendor.js:3774:1
 Object.options.factory
  runtime.js:675:31
webpack_require
  runtime.js:36:33
 fn
  runtime.js:346:21

Creating new issue because #66 is closed

@aleksandrlat
Copy link
Author

Looks like nothing is exported from from require( './lib' ) now or require( './lib' ).PhoneNumber does not exist anymore
image

Looks like upgrade to new closure compiler didn't work well.

@bgneu
Copy link

bgneu commented Sep 30, 2021

Facing a similar issue using this package in React Native.

@github-actions
Copy link

github-actions bot commented Oct 2, 2021

🎉 This issue has been resolved in version 2.62.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@grantila
Copy link
Owner

grantila commented Oct 2, 2021

I think this is fixed now. I've made a small webpack example where it runs fine.

@DorianMaliszewski
Copy link

Hi 😄,

FYI this issue still here in 2.62.1. I needed to downgrade to 2.59.0 to make it works again.

Thanks for all 💪

@grantila
Copy link
Owner

@DorianMaliszewski would you mind testing 2.63.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants