Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong recognition of region code #31

Closed
omerts opened this issue Jul 14, 2019 · 4 comments
Closed

Wrong recognition of region code #31

omerts opened this issue Jul 14, 2019 · 4 comments
Labels
released

Comments

@omerts
Copy link

omerts commented Jul 14, 2019

Currently the region code recognition, takes into account the first 4 digits, as minimum as possible, in order to try to figure out the region code. This is problematic for shared region codes such as 1, that is used both for US and Canada. This means that currently, no Canadian number is recognized as such, unless an explicit country code is passed.
@omerts
Copy link
Author

omerts commented Jul 14, 2019

Created PR #32

@omerts omerts mentioned this issue Jul 14, 2019
Closed
@grantila
Copy link
Owner

Oh, sounds related to #30

@grantila
Copy link
Owner

I want to minimize the number of parse calls to libphonenumber to make this as fast as possible so I have a similar fix ongoing.

@grantila
Copy link
Owner

🎉 This issue has been resolved in version 2.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@omerts @grantila