Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Registering specifc ServiceEntries #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

celebdor
Copy link

This patch allows the library user more control in the registry flow by
giving them the chance to pass the ServiceEntries they crafted.

@celebdor
Copy link
Author

This patch allows the library user more control in the registry flow by
giving them the chance to pass the ServiceEntries they crafted.
Copy link
Owner

@grandcat grandcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the benefit over Register?
Given there should be an extended API, code should be reused rather than duplicated.

Also, test coverage should be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants