Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase scheduler worker cancellation chan cap #741

Merged
merged 6 commits into from
Jan 14, 2022
Merged

Increase scheduler worker cancellation chan cap #741

merged 6 commits into from
Jan 14, 2022

Commits on Jan 13, 2022

  1. Increase scheduler worker cancellation chan cap 

    With previous implementation, if worker was busy talking to scheduler,
we didn't push the cancellation, keeping that query running.

When cancelling a query, all its subqueries are cancelled at the same
time, so this was most likely happening all the time (first subquery
scheduled on this worker was canceled, the rest were not because worker
was busy cancelling the first one).

Also removed the `<-ctx.Done()` escape point when waiting for the
enqueueing ACK and modified the enqueueing method to ensure that it
always responds something.

Fixes: #740
Inspired by: grafana/loki#5113

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
    @colega
    colega committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    cf1eb2a View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md 

    Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
    @colega
    colega committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    73e2bea View commit details
    Browse the repository at this point in the history

  3. Remove comment about chan memory usage 

    Co-authored-by: Peter Štibraný <peter.stibrany@grafana.com>
    @colega @pstibrany
    colega and pstibrany authored Jan 13, 2022
    Configuration menu
    Copy the full SHA
    75e2790 View commit details
    Browse the repository at this point in the history

  4. Update test comment 

    Co-authored-by: Peter Štibraný <peter.stibrany@grafana.com>
    @colega @pstibrany
    colega and pstibrany authored Jan 13, 2022
    Configuration menu
    Copy the full SHA
    a4b9111 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. Add resp.Error to the log when response is unknown 

    Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
    @colega
    colega committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    196a914 View commit details
    Browse the repository at this point in the history

  2. Log the entire uknown response 

    Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
    @colega
    colega committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    cc7ee62 View commit details
    Browse the repository at this point in the history