Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/promtail/positions: remove executable bit from positions file #893

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Aug 13, 2019

File permissions on creation of positions.yaml will now be 0600 instead of 0700.

Fixes #892.

@rfratto rfratto requested a review from slim-bean August 13, 2019 12:27
Copy link
Member

@sh0rez sh0rez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

File permissions on creation of positions.yaml will now be 0600
instead of 0700.

Fixes grafana#892.
@rfratto rfratto merged commit 001d36f into grafana:master Aug 13, 2019
@rfratto rfratto deleted the positions_perm_fix branch August 13, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

positions.yaml is create with 700 mode
2 participants