added missed binaries required to run ./tools/image-tag script
#8640
Conversation
|
Ah. nvm. PR description make it clear. |
| @@ -707,6 +707,8 @@ local manifest_ecr(apps, archs) = pipeline('manifest-ecr') { | |||
| image: 'alpine', | |||
| depends_on: ['check-version-is-latest'], | |||
| commands: [ | |||
| 'apk add --no-cache bash git', | |||
There was a problem hiding this comment.
Out of interest, can we not just use ash instead?
There was a problem hiding this comment.
You mean sh instead of bash?
+ RELEASE_TAG=$(./tools/image-tag)
env: can't execute 'bash': No such file or directory
I guess our image-tag requires bash looks like.
There was a problem hiding this comment.
No, I mean ash which is the default shell of Alpine
There was a problem hiding this comment.
We have #!/usr/bin/env bash in the header of image-tag, which is probably unnecessary.
There was a problem hiding this comment.
We have #!/usr/bin/env bash in the header of image-tag, which is probably unnecessary.
yep, nothing bash specific is used in the script )) so I believe we can remove the header from the script or make it flexible to be able to run in any terminal...
anyway, not only bash was missed, git is also required, so let's merge this PR and update ./tools/image-tag script when we have time and need ))
vlad-diachenko
added
type/bug
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-8640-to-release-2.7.x origin/release-2.7.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 88120a0857af4e45e204185117d7a32bbca2478f
# Push it to GitHub
git push --set-upstream origin backport-8640-to-release-2.7.x
git switch main
# Remove the local backport branch
git branch -D backport-8640-to-release-2.7.xThen, create a pull request where the |
What this PR does / why we need it:
This drone step had to prepare a config for the
updaterto update loki helm chart with the latest image version automatically. However, it failed due to an error:I forgot to install
bashandgitbefore running this script insidealpinecontainer.