Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Be able to customize the Namespace #830

Merged
merged 5 commits into from
Aug 1, 2019

Conversation

mmatur
Copy link
Contributor

@mmatur mmatur commented Aug 1, 2019

What this PR does / why we need it:

When I run the command helm upgrade --install loki --namespace=loki-stack loki/loki-stack, I expect to have loki installed in the loki-stack namespace.

This PR allows users to customize namespace installation with flag --namespace.

Checklist

  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! LGTM

@cyriltovena cyriltovena merged commit 664537e into grafana:master Aug 1, 2019
@mmatur mmatur deleted the feature/helm-namespace-loki branch August 1, 2019 13:45
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
* Add release namespace for loki

* Add Release namespace for promtail chart

* Add Release namespace for loki-stack chart

* Add doumentation

* Increase chart version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants