Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lambda-promtail: Add kinesis data stream to use in terraform #7632

Conversation

changhyuni
Copy link
Contributor

@changhyuni changhyuni commented Nov 8, 2022

What this PR does / why we need it:
#5977
With the addition of the kinesis data stream function add kinesis data stream to use in terraform

Which issue(s) this PR fixes:

Special notes for your reviewer:
due to cla assistant issue re pr #7239
@kavirajk
@MichelHollands

Checklist

  • Reviewed the CONTRIBUTING.md guide
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@changhyuni changhyuni requested a review from a team as a code owner November 8, 2022 15:49
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 8, 2022
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

-           ingester	-0.1%
+        distributor	0%
+            querier	0%
- querier/queryrange	-0.1%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@changhyuni
Copy link
Contributor Author

@kavirajk
@MichelHollands
Hi,
I made a new pr because of the cla assistant issue. Please note that there is no difference from the previous pr.
thank you, have a nice day!

@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichelHollands MichelHollands merged commit 3f59fa9 into grafana:main Nov 9, 2022
Abuelodelanada pushed a commit to canonical/loki that referenced this pull request Dec 1, 2022
…#7632)

**What this PR does / why we need it**:
grafana#5977
With the addition of the kinesis data stream function add kinesis data
stream to use in terraform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants