Loki: Revert #4845 which changed the format of errors from the API #5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt type from plain text to JSON is a breaking change of the API and we should wait to do this at a major release. Signed-off-by: Ed Welch <edward.welch@grafana.com>
slim-bean
added
the
backport release-2.5.x
Signed-off-by: Ed Welch <edward.welch@grafana.com>
chaudum
approved these changes
Apr 5, 2022
owen-d
approved these changes
Apr 5, 2022
|
Should the change log entry also be reverted? |
grafanabot
pushed a commit
that referenced
this pull request
Apr 5, 2022
…5772) * This reverts the changes from #4845, unfortunately changing the content type from plain text to JSON is a breaking change of the API and we should wait to do this at a major release. Signed-off-by: Ed Welch <edward.welch@grafana.com> * fix tests which were updated after initial change. Signed-off-by: Ed Welch <edward.welch@grafana.com> (cherry picked from commit c158b2c)
slim-bean
added a commit
that referenced
this pull request
Apr 6, 2022
…5772) (#5774) * This reverts the changes from #4845, unfortunately changing the content type from plain text to JSON is a breaking change of the API and we should wait to do this at a major release. Signed-off-by: Ed Welch <edward.welch@grafana.com> * fix tests which were updated after initial change. Signed-off-by: Ed Welch <edward.welch@grafana.com> (cherry picked from commit c158b2c) Co-authored-by: Ed Welch <edward.welch@grafana.com>
splitice
pushed a commit
to X4BNet/loki
that referenced
this pull request
May 21, 2022
… API (grafana#5772) (grafana#5774) * This reverts the changes from grafana#4845, unfortunately changing the content type from plain text to JSON is a breaking change of the API and we should wait to do this at a major release. Signed-off-by: Ed Welch <edward.welch@grafana.com> * fix tests which were updated after initial change. Signed-off-by: Ed Welch <edward.welch@grafana.com> (cherry picked from commit c158b2c) Co-authored-by: Ed Welch <edward.welch@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
PR #4845 changed the return type of error messages from plain text to JSON.
This PR was actually fixing a problem with the current API which returns plain text and sets a
Content-Typeheader ofapplication/jsonbut then returns plain text. The problem is it's significantly changing the behavior of the API which should be considered a breaking change and we should wait to do this at the next major release.It's entirely possible anyone who's implemented their own code against the Loki API are expecting the error messages in their current format and even though this is a "fix" it would break those users so we want to wait to do this until a future major release.