Disable sharding of count/avg when labels are mutated #5474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
approved these changes
Feb 24, 2022
| @@ -964,6 +962,18 @@ func (e *VectorAggregationExpr) String() string { | |||
|
|
|||
| // impl SampleExpr | |||
| func (e *VectorAggregationExpr) Shardable() bool { | |||
| if e.Operation == OpTypeCount || e.Operation == OpTypeAvg { | |||
There was a problem hiding this comment.
We really need a way to express operations that aren't always or never shardable, but shardable depending on how they're combined with other operations. This is a great start 👍.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Counting distinct values cannot be sharded when mutating labels over multiple shards, since the same label can appears across multiple shard and will be counted twice.
Since avg() uses count then the same logic is applied for it too.
Which issue(s) this PR fixes:
Fixes #5461
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.