Fix circular dependencies on k3d desployment #5420
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes circular dependencies in the
loki-distributed
make target.Special notes for your reviewer:
When running
make loki-distributed
the following error was prtiented:This is due to the
loki-distributed
make target depending on theprepare
target which will try to push the loki image to thek3d-grafana
container registry.Problem is, that would only work if the
k3d-grafana
cluster is already created. Which is not since it’s created on thecreate_cluster.sh
script which will be run after theprepare
target.Checklist
CHANGELOG.md
about the changes.