Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular dependencies on k3d desployment #5420

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

salvacorts
Copy link
Contributor

What this PR does / why we need it:
This PR fixes circular dependencies in the loki-distributed make target.

Special notes for your reviewer:
When running make loki-distributed the following error was prtiented:

Get "http://k3d-grafana:45629/v2/": dial tcp 127.0.0.1:45629: connect: connection refused

This is due to the loki-distributed make target depending on the prepare target which will try to push the loki image to the k3d-grafana container registry.

Problem is, that would only work if the k3d-grafana cluster is already created. Which is not since it’s created on the create_cluster.sh script which will be run after the prepare target.

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

@salvacorts salvacorts requested a review from a team as a code owner February 17, 2022 11:19
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 651ac09 into main Feb 25, 2022
@cyriltovena cyriltovena deleted the salvacorts/fix-k3d-deployment branch February 25, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants