Build: simplify make targets to just run every time #5411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…run them every time. Signed-off-by: Edward Welch <edward.welch@grafana.com>
Signed-off-by: Edward Welch <edward.welch@grafana.com>
…o versions 13/14/15 Signed-off-by: Edward Welch <edward.welch@grafana.com>
…I guess this all happens in the same place at the same time in drone. Signed-off-by: Edward Welch <edward.welch@grafana.com>
Signed-off-by: Edward Welch <edward.welch@grafana.com>
slim-bean
force-pushed
the
make-build-ever-time
branch
from
c91f888
to
98cea8c
Compare
slim-bean
commented
Feb 21, 2022
| @@ -353,7 +353,7 @@ local manifest(apps) = pipeline('manifest') { | |||
| image: 'koalaman/shellcheck-alpine:stable', | |||
| commands: ['apk add make bash && make lint-scripts'], | |||
| }, | |||
| make('loki', container=false) { depends_on: ['clone'] }, | |||
| make('loki', container=false) { depends_on: ['clone', 'check-generated-files'] }, | |||
There was a problem hiding this comment.
this is necessary because previously we ran check-generated-files at the same time as make loki, the former runs a clean operation which removes the protos and then the make loki would fail because the protos were missing. This worked previously because the make loki step had a dependency to generate the protos and this PR removes that.
dannykopping
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If I had a dollar for every time we had build failures related to file modified times and
make.....This PR removes any dependant targets from our binary build commands such that they run every time, I'm tired of chasing down weird modified time bugs related to git checkouts and file changes because git doesn't store timestamps and thus this functionality in make is extremely brittle and wastes more time than it ever saved.
We have separate checks in our CI to make sure generated assests are regenerated if they are changed, we don't need to do that as part of something like
make lokiNOTE: While troubleshooting what turned out to be a drone issue, I also removed all the
mod=vendorstuff we had in place to work through the migration of go from versions 1.13-1.16 which I'm about 99% sure isn't necessary anymore.Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.