Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Use output plugin grafana-loki in ECS #5386

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

jrykr
Copy link
Contributor

@jrykr jrykr commented Feb 14, 2022

Reflects name change in v2.1.0.

  • If an ECS user configures "Name": "loki" then the native output plugin will be used and the task configuration crashes in ECS.

What this PR does / why we need it:
The current example will not run in ECS.

Which issue(s) this PR fixes:
Fixes n/a

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

Reflects name change in v2.1.0.

- If an ECS user configures `"Name": "loki"` then the native output plugin will be used and the task configuration crashes in ECS.
@CLAassistant
Copy link

CLAassistant commented Feb 14, 2022

CLA assistant check
All committers have signed the CLA.

@jrykr
Copy link
Contributor Author

jrykr commented Feb 14, 2022

CLA Assistant does not seem to be working for me.

image

@jrykr
Copy link
Contributor Author

jrykr commented Feb 14, 2022

CLA Assistant does not seem to be working for me.

Resolved.

@KMiller-Grafana KMiller-Grafana requested a review from a team February 15, 2022 23:19
Copy link
Contributor

@KMiller-Grafana KMiller-Grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM. Needs a quick review by a developer on the team with ECS experience.

Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KMiller-Grafana KMiller-Grafana merged commit 39e9c14 into grafana:main Feb 17, 2022
@jrykr jrykr deleted the patch-1 branch February 23, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants