add more context to logs, improve comments for clarity in boltdb-shipper code #5341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeepsukhani
force-pushed
the
boltdb-shipper-logging-comments-improvements
branch
from
57e1ff8
to
709c59b
Compare
MasslessParticle
approved these changes
Feb 8, 2022
sandeepsukhani
force-pushed
the
boltdb-shipper-logging-comments-improvements
branch
from
709c59b
to
c2d22a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
user-idto logs when working on user-specific index and logging on it.user_idlabel onloki_boltdb_shipper_retention_marker_table_processed_totalso that we can track actions done on user-specific index in the tables.