Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated documentation for xk6-loki extension #5321

Merged
merged 5 commits into from
Feb 11, 2022

Conversation

vlad-diachenko
Copy link
Contributor

@vlad-diachenko vlad-diachenko commented Feb 4, 2022

What this PR does / why we need it:
documented custom k6 metrics that xk6-loki extension reports for instant and range queries. these metrics were added in grafana/xk6-loki#26

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
@vlad-diachenko
Copy link
Contributor Author

@chaudum done

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 0e51896 into main Feb 11, 2022
@cyriltovena cyriltovena deleted the documented_custom_k6_metrics_for_read_path branch February 11, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants