Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filters: use faster regexp package #5315

Merged
merged 3 commits into from
Feb 7, 2022
Merged

filters: use faster regexp package #5315

merged 3 commits into from
Feb 7, 2022

Commits on Feb 4, 2022

  1. regexp-filter: improve benchmark

    Add a few more cases based on real-world usage.
    
    Also simplify the loop to just run the number of times requested.
    Go benchmarks run 'N' times to reach a duration, default 1 second.
    Previously the benchmark was running N*1000000 times, which
    took 7 seconds minimum for some cases.
    bboreham committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    1492575 View commit details
    Browse the repository at this point in the history
  2. regexp filter: use modified package with optimisations

    See https://github.com/grafana/regexp/tree/speedup#readme
    
    Includes the following changes proposed upstream:
    * [regexp: allow patterns with no alternates to be one-pass](https://go-review.googlesource.com/c/go/+/353711)
    * [regexp: speed up onepass prefix check](https://go-review.googlesource.com/c/go/+/354909)
    * [regexp: handle prefix string with fold-case](https://go-review.googlesource.com/c/go/+/358756)
    * [regexp: avoid copying each instruction executed](https://go-review.googlesource.com/c/go/+/355789)
    * [regexp: allow prefix string anchored at beginning](https://go-review.googlesource.com/c/go/+/377294)
    bboreham committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    380f8eb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    55094b3 View commit details
    Browse the repository at this point in the history