Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse duration expressions in accordance with promql #5275

Merged
merged 6 commits into from
Feb 22, 2022
Merged

Parse duration expressions in accordance with promql #5275

merged 6 commits into from
Feb 22, 2022

Commits on Feb 20, 2022

  1. Add support for Prometheus like duration units in logql

    @SasSwart
    SasSwart committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    f5cc1cb View commit details
    Browse the repository at this point in the history

  2. Remove redundant type conversion

    @SasSwart
    SasSwart committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    e6d347a View commit details
    Browse the repository at this point in the history

  3. deduplicate call to sb.String 

    Add a comment to explain why both promql and time's ParseDuration methods are used
    @SasSwart
    SasSwart committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    5c8b58c View commit details
    Browse the repository at this point in the history

  4. extract duration parsing to separate function.

    @SasSwart
    SasSwart committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    19f57e3 View commit details
    Browse the repository at this point in the history

  5. Add tests to ensure promql duration units are supported

    @SasSwart
    SasSwart committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    938ab97 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. Sort duration rune comment and list of runes in ascending order of le… 

    …ngth.
    @SasSwart
    SasSwart committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    70efae1 View commit details
    Browse the repository at this point in the history