Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update memory ballast documentation #5106

Merged
merged 10 commits into from
Jan 14, 2022

Conversation

SasSwart
Copy link
Contributor

@SasSwart SasSwart commented Jan 12, 2022

What this PR does / why we need it:
My previous PR was merged before I had resolved the documentation review notes.
This PR brings the documentation in line with what was requested by the reviewer.

Which issue(s) this PR fixes:
Fixes remaining review notes from PR 5081

Special notes for your reviewer:
Review Notes:
#5081 (review)
#5081 (comment)

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

@SasSwart SasSwart marked this pull request as ready for review January 12, 2022 09:00
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SasSwart 👍

Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing a follow up PR!

Copy link
Contributor

@KMiller-Grafana KMiller-Grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra step to revise the documentation.

@dannykopping dannykopping merged commit 205ad61 into grafana:main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants