Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix promtail docs links in loki installation page #4601

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

mustafacansevinc
Copy link
Contributor

What this PR does / why we need it: fixes link to "syslog-reciever" and "systemd-journal" config docs

Which issue(s) this PR fixes: -

Special notes for your reviewer: -

Checklist

  • Documentation added
  • Tests updated

fixes link to "syslog-reciever" and "systemd-journal" config docs

Signed-off-by: Mustafa Can Sevinç <mcansevinc@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Nov 1, 2021

CLA assistant check
All committers have signed the CLA.

@mustafacansevinc mustafacansevinc marked this pull request as draft November 1, 2021 07:28
Signed-off-by: Mustafa Can Sevinç <mcansevinc@gmail.com>
@mustafacansevinc mustafacansevinc marked this pull request as ready for review November 1, 2021 07:44
Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mustafacansevinc Thanks for the fix :).

Added few minor suggestions!

docs/sources/installation/helm.md Show resolved Hide resolved
docs/sources/installation/helm.md Show resolved Hide resolved
Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@owen-d owen-d merged commit 2a1d800 into grafana:main Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants